Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.12.16.00 #201422

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.12.16.00 #201422

wants to merge 9 commits into from
+24 −30

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333
Copy link
Member Author 

  [ 35%] Generating protocolconformance files. Output: /tmp/fbthrift-20241216-47091-ojp2mm/fbthrift-2024.12.16.00/build/shared/thrift/lib/cpp2/test/../../../conformance/if
  cd /tmp/fbthrift-20241216-47091-ojp2mm/fbthrift-2024.12.16.00/build/shared/thrift/lib/cpp2/test && ../../../../bin/thrift1 --gen mstch_cpp2:frozen2,include_prefix=thrift/conformance/if -o /tmp/fbthrift-20241216-47091-ojp2mm/fbthrift-2024.12.16.00/build/shared/thrift/lib/cpp2/test/../../../conformance/if -I /tmp/fbthrift-20241216-47091-ojp2mm/fbthrift-2024.12.16.00 /tmp/fbthrift-20241216-47091-ojp2mm/fbthrift-2024.12.16.00/thrift/lib/cpp2/test/../../../conformance/if/protocol.thrift
  Output path /tmp/fbthrift-20241216-47091-ojp2mm/fbthrift-2024.12.16.00/build/shared/thrift/lib/cpp2/test/../../../conformance/if is unusable or not a directory
  make[2]: *** [thrift/conformance/if/gen-cpp2/protocol_constants.h] Error 1
  make[1]: *** [thrift/lib/cpp2/test/CMakeFiles/protocolconformance-cpp2-target.dir/all] Error 2

same issue as before

@chenrui333 chenrui333 added the build failure CI fails while building the software label Dec 16, 2024
@daeho-ro daeho-ro closed this Dec 16, 2024
@github-actions github-actions bot deleted the fb-20241216 branch December 16, 2024 23:07
@daeho-ro daeho-ro mentioned this pull request Dec 16, 2024
Closed
6 tasks
@daeho-ro daeho-ro restored the fb-20241216 branch December 16, 2024 23:07
@daeho-ro daeho-ro reopened this Dec 16, 2024
@daeho-ro
Copy link
Member

daeho-ro commented Dec 17, 2024 •
edited
Loading

Recently they have added some tests for cpp2

And I want it to be get rid off but not working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build failure CI fails while building the software
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @daeho-ro